feat(recce-review): pre-flight check for missing recce install#27
Open
kentwelcome wants to merge 1 commit intomainfrom
Open
feat(recce-review): pre-flight check for missing recce install#27kentwelcome wants to merge 1 commit intomainfrom
kentwelcome wants to merge 1 commit intomainfrom
Conversation
Add a Pre-flight step to the /recce-review skill that probes for the `recce` CLI (auto-activating venv/.venv to mirror run-mcp-stdio.sh) and stops with a clear install hint when missing — so users learn about the problem up front instead of via a silent MCP tool failure mid-review. Also align session-start.sh's install hint to use `pip install 'recce[mcp]'` for consistency with the new skill message. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adds an explicit pre-flight check to the /recce-review skill to detect whether the recce CLI is available (including via local venv/ or .venv/ activation) and provide a clear install hint up front, and aligns the session-start hook’s install guidance with the new message.
Changes:
- Add a
/recce-reviewpre-flight step to probe forrecceand stop early with install instructions when missing. - Introduce
check-recce-installed.shto mirror the MCP stdio launcher’s venv auto-detection and report readiness. - Update
session-start.shto recommendpip install 'recce[mcp]'in its remediation hint.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| plugins/recce/skills/recce-review/SKILL.md | Adds a pre-flight step and user-facing install guidance for missing recce. |
| plugins/recce/skills/recce-review/scripts/check-recce-installed.sh | New probe script that auto-detects/activates venv and reports recce availability/version. |
| plugins/recce/hooks/scripts/session-start.sh | Aligns install hint to pip install 'recce[mcp]'. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+39
to
+41
| The script auto-activates a local `venv/` or `.venv/` (mirroring `run-mcp-stdio.sh`) and prints `RECCE=ready` (with `RECCE_VIA` and `RECCE_VERSION`) or `RECCE=missing`. | ||
|
|
||
| - `RECCE=ready` — continue to Step 0. |
Comment on lines
+13
to
+15
| source "$VENV_DIR/bin/activate" | ||
| RECCE_VIA=venv | ||
| break |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/recce-reviewskill that probes for therecceCLI (auto-activatingvenv//.venv/to mirrorrun-mcp-stdio.sh) and stops with a clear install hint when missing — so users learn about the problem up front instead of via a silent MCP tool failure mid-review.session-start.sh's install hint to usepip install 'recce[mcp]'for consistency with the new skill message.Why
Without this check, when
recceis not installed the stdio MCP launcher silently fails. The user gets no obvious signal — they only discover the problem when an MCP tool call eventually errors out (or via/mcpif they happen to look). The Pre-flight surfaces it immediately when/recce-reviewis invoked.Test plan
/recce-reviewproceeds past Pre-flight (RECCE=ready)./recce-reviewstops at Pre-flight with the install instructions..venv/containing recce: Pre-flight auto-activates and reportsRECCE=readywithRECCE_VIA=venv.session-start.shhint output usespip install 'recce[mcp]'.🤖 Generated with Claude Code